D10857: Change qSort to std::sort in simplifiedUrlList

[Mark Gaiser]

markg added a comment.


  In D10857#216725 <https://phabricator.kde.org/D10857#216725>, @dfaure wrote:
  
  > I cannot confirm that stable_sort is faster, on the contrary. http://www.davidfaure.fr/2018/qsort_performance.cpp updated, says (repeatedly)
  >  "std::sort took: 5003 ms"
  >  "std::stable_sort took: 7490 ms"
  >
  > Maybe on specific data (the actual filenames you're testing this with), stable_sort ends up being faster, but this isn't true in general (with random data).
  
  
  "qSort took: 3308 ms"
  "std::sort took: 3383 ms"
  "std::stable_sort took: 5829 ms"
  
  My results. A direct copy-paste from your benchmark, no edits.
  Release mode and linux this time.
  
  @jtamate std::sort it is. Feel free to commit :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

To: jtamate, #frameworks, dfaure, markg
Cc: markg, apol, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180302/4dcef2f2/attachment.html>