D10857: Change qSort to std::sort in simplifiedUrlList
Jaime Torres Amate
noreply at phabricator.kde.org
Fri Mar 2 08:21:00 UTC 2018
jtamate added a comment.
I've found the problem. The problem is qSort itself.
Chaning qSort to qStableSort I've got normal times in the test case, select 50.000 files and pressing Shift+Supr.
Also in the small test, the times, running under callgrind are:
qSort: between 33148 and 45745
std::sort between 53231 and 66780
qStableSort: between 11232 and 15116
std::stable_sort: between 22581 and 25957
Therefore, before patching, should I change all of them to std::sort or std::stable_sort or qStableSort?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10857
To: jtamate, #frameworks, dfaure, markg
Cc: markg, apol, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180302/77ec3ed2/attachment.html>
More information about the Kde-frameworks-devel
mailing list