D10803: handle more tags in taglibextractor
Michael Heidelbach
noreply at phabricator.kde.org
Fri Mar 2 08:12:55 UTC 2018
michaelh added inline comments.
INLINE COMMENTS
> taglibextractortest.cpp:82
>
> QCOMPARE(resultFlac.properties().value(Property::Title), QVariant(QStringLiteral("Title")));
> QCOMPARE(resultFlac.properties().value(Property::Artist), QVariant(QStringLiteral("Artist")));
Just a hint: The code would be easier to read if the title of the sample file was
'I love you so much' or 'Desaster will come' just not the same as the propery name. (Same for most of the props below)
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D10803
To: astippich, mgallien, ngraham
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180302/bf35d464/attachment.html>
More information about the Kde-frameworks-devel
mailing list