D10551: autotest for crashing in KArchiveDirectory::addEntry

Martin Tobias Holmedahl Sandsmark noreply at phabricator.kde.org
Thu Mar 1 09:51:39 UTC 2018


sandsmark marked an inline comment as done.
sandsmark added a comment.


  test file was from a customer, but it's from a public

INLINE COMMENTS

> dfaure wrote in karchivetest.cpp:1172
> This detaches the list, put it in a const local variable.
> 
> (standard range-for trap with Qt containers)

the performance impact here was negligible so I preferred to keep the code simpler, but changed it now

REVISION DETAIL
  https://phabricator.kde.org/D10551

To: sandsmark, dfaure, apol
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180301/32fd8604/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list