D13808: Fix KMainWindow saving incorrect widget settings

Mladen Milinkovic noreply at phabricator.kde.org
Sat Jun 30 23:51:12 UTC 2018


maxrd2 added a comment.


  The change in qt affects when the window close event is handled in queue, it didn't change when it is fired. With qt 5.11.1 child widgets get destroyed a bit sooner, but it's still gets triggered by same close event - i think that stayed like it always was.
  Also KMainWindow code is made to autosave settings (if not disabled) every time some relevant widget changes, so am pretty sure that this patch won't ever cause it to save incorrect settings.
  Window/widget visibility and size is unlikely to change by user after they click to close window.
  
  However to be 100% sure will submit the test.

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180630/6147e46a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list