D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

[René J.V. Bertin]

rjvbb marked 2 inline comments as done.
rjvbb added inline comments.

INLINE COMMENTS

> ngraham wrote in kmessagewidget.cpp:311
> I don't think all of this complicated code is necessary. The theme itself is supposed to ensure readability with the colors that it uses. Also, this results in a slight regression for the Breeze Dark theme: the Information widget doesn't get enough alpha and is too bright, worsening readability compared to the status quo.

The issue I have with using these colours is that they are foreground colours, to be used against one of 2 or 3 background colours. *That* is what the theme can be expected to ensure.

There is however no obstacle whatsoever to introducing a few new colour categories, specifically for this use. Only then can you blame the theme if things don't work out.

I can modify (and maybe simplify) the alpha calculation of course.

Here's what my theme gives with the tweaked alpha. Without that, information messages would be a darker red than error messages. That would be wrong, but I don't see how there's anything wrong with using a dark red for active text and a brighter red for negative. Red on grey works very nicely for text that should draw attention.

F5967735: Screen Shot 2018-06-28 at 19.18.55.png <https://phabricator.kde.org/F5967735>

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180628/c9b2dea2/attachment.html>