text search balloon background colour

René J. V. Bertin rjvbertin at gmail.com
Thu Jun 28 08:32:00 UTC 2018


Kai Uwe Broulik wrote:

Hi,

> it was adjusted to more closely resemble the Breeze visual style. The colors
> are unfortunately hardcoded as KWidgetAddons as a Tier 1 framework cannot
> depend on KColorScheme.

Yeah, that's not good, hardcoding colours is in fact a bug because it can lead 
to something unreadable (for a variety of reasons including allergy to blue ;)).

Instead the appropriate colour should be read from kdeglobals, or else, why not 
simply use the tooltip background colour? I'm pretty certain you can retrieve 
that QColor with pure Qt calls, which may or may not go through a platform theme 
plugin that does access KColorScheme or gets the colour from the widget style in 
use.

At a minimum, Breeze tweaks should be applied only when using the Breeze widget 
style (which can be determined with pure Qt calls).

I'll try to look into this; are we talking about commit 
00bce130d35e9dc398709e690a05f8dde70f52b3 or 
159c6950e39968f12b6366fb167bfd441c92bf5b?

R.



More information about the Kde-frameworks-devel mailing list