D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR
Christophe Giboudeaux
noreply at phabricator.kde.org
Tue Jun 26 09:55:08 UTC 2018
cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.
In D13406#277236 <https://phabricator.kde.org/D13406#277236>, @habacker wrote:
>
> BTW: I was faced to this on trying to understand the ki1i8n build system, from which I took the macro file and all related dependencies to install po files from a tarball released by KDE for a cross build umbrello for Windows (see https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-umbrello), which cant use the full KI18n package for now.
So, you're using files from the ki18n build system, installed in cmake/KF5I18n/ to indicate it's not supposed to be used for another purpose to build a KDE4 app... well ok.
INLINE COMMENTS
> CMakeLists.txt:56-59
> +configure_file(${KI18n_SOURCE_DIR}/cmake/build-pofiles.cmake ${KI18n_BINARY_DIR}/cmake/build-pofiles.cmake COPYONLY)
> +configure_file(${KI18n_SOURCE_DIR}/cmake/build-tsfiles.cmake ${KI18n_BINARY_DIR}/cmake/build-tsfiles.cmake COPYONLY)
> +configure_file(${KI18n_SOURCE_DIR}/cmake/ts-pmap-compile.py ${KI18n_BINARY_DIR}/cmake/ts-pmap-compile.py COPYONLY)
> +configure_file(${KI18n_SOURCE_DIR}/cmake/kf5i18nuic.cmake ${KI18n_BINARY_DIR}/cmake/kf5i18nuic.cmake COPYONLY)
file(COPY ...
is fine for the 4 files. No need to replace it
REPOSITORY
R249 KI18n
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13406
To: habacker, ilic, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180626/e90ad7ce/attachment.html>
More information about the Kde-frameworks-devel
mailing list