D13730: Fix memory management in WaylandOutputManagement

David Edmundson noreply at phabricator.kde.org
Mon Jun 25 23:50:50 UTC 2018


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There was no destructor in the protocol, which meant the auto generated
  _destroy function only deletes the wl_proxy object, but doesn't actually
  send anything to the server.
  
  Result was OutputConfiguration objects on
  the server just linger forever and it's a broken state

TEST PLAN
  Added unit test that objects have the lifespan they should do

REPOSITORY
  R127 KWayland

BRANCH
  dave

REVISION DETAIL
  https://phabricator.kde.org/D13730

AFFECTED FILES
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/protocols/output-management.xml
  src/server/outputconfiguration_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180625/f2a11916/attachment.html>


More information about the Kde-frameworks-devel mailing list