D13718: Support choosing .ico files in custom icon file chooser
Nathaniel Graham
noreply at phabricator.kde.org
Mon Jun 25 13:21:28 UTC 2018
ngraham created this revision.
ngraham added reviewers: Frameworks, cfeck.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
.ico files work fine, so we should allow them to be chosen in the custom icon file chooser dialog/
BUG: 233201
FIXED-IN: 5.48
TEST PLAN
- Find a .ico file lying around, or turn a .png file into a .ico file using https://convertico.com/
- Typ to apply it to a folder in Dolphin
- You can select the .ico file in the dialog, and when applied, it appears correctly as a custom icon for the folder
REPOSITORY
R302 KIconThemes
BRANCH
ico-support-in-icon-file-chooser-dialog (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D13718
AFFECTED FILES
src/kicondialog.cpp
To: ngraham, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180625/f2772d93/attachment.html>
More information about the Kde-frameworks-devel
mailing list