D13706: [KMoreTools] Enable installing tools via appstream url

gregormi noreply at phabricator.kde.org
Sun Jun 24 21:06:40 UTC 2018


gregormi added inline comments.

INLINE COMMENTS

> kmoretools.h:500
> +     */
> +    void setAppstreamUrl(const QUrl& url);
> +

I am not so familiar with appstream. Why not only setting the COMPONENT-ID instead of the whole URL? Then the method would be named setAppstreamComponentId.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180624/729ea391/attachment.html>


More information about the Kde-frameworks-devel mailing list