D13601: OutputManagement fractional scaling

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> outputdevice_interface.cpp:449
>  SETTER(setScale, int, scale)
> +SETTER(setScaleF, qreal, scale)
>  SETTER(setSubPixel, SubPixel, subPixel)

The macro does not do a fuzzy compare.

> outputdevice_interface.h:138
>      void refreshRateChanged(int);
> +    //@deprecated see scaleChanged(real)
>      void scaleChanged(int);

You mean: `scaleFChanged(qreal)` ?

> outputdevice_interface.h:140
>      void scaleChanged(int);
> +    void scaleFChanged(qreal);
>      void subPixelChanged(SubPixel);

This signal is never used (neither connected in the constructor nor emitted in the macro).

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13601

To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180623/7b149d81/attachment-0001.html>