D13695: Make sure KLineEdit::clearButtonClicked is emitted

Albert Astals Cid noreply at phabricator.kde.org
Sat Jun 23 11:00:23 UTC 2018


aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Even when calling setClearButtonEnabled instead of setClearButtonShown
  
  Recently KLineEdit::setClearButtonShown got deprecated, but that meant
  that silently &KLineEdit::clearButtonClicked would not be emitted.
  
  This patch corrects it. It uses quite a bit of internal magic, but
  the old one was already using some so i think it's ok, given it even
  comes with an autotest that will break when Qt changes its internals

TEST PLAN
  Test passes :)

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13695

AFFECTED FILES
  autotests/klineedit_unittest.cpp
  src/klineedit.cpp
  tests/klineedittest.cpp

To: aacid
Cc: davidedmundson, kde-frameworks-devel, broulik, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180623/2a8b315b/attachment.html>


More information about the Kde-frameworks-devel mailing list