D13627: [KIconThemes] Isolate private data from race conditions

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Holy crap, now MutexGuard doesn't even guarantee that the mutex will be locked, and yet you proceed, without the mutex locked, creating race conditions.
  
  Are you reading any of my comments?
  
  A very very strong -2 to this patch.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13627

To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180622/7d41d4c5/attachment.html>