D13535: Do not cancel old clipboard selection if it is same as the new one.

[Roman Gilg]

romangg added a comment.


  In D13535#278441 <https://phabricator.kde.org/D13535#278441>, @fvogt wrote:
  
  > in TestDataDevice::testReplaceSource() and it fails without this patch.
  >  With this patch however, the selection isn't offered (is that correct behaviour?) so the wait() times out.
  >  Is there a better way to test this?
  
  
  I did some research and yes, it's the correct behavior in my opinion: selectionOffered is emitted on receiving a selection event. According to Wayland documentation:
  
  > The selection event is sent out to notify the client of a new wl_data_offer for the selection for this device.
  
  Since there is no new selection the old wl_data_source and wl_data_offer do still exist (selection->cancel() just below your insertion was never called) and a new selection event won't get sent.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13535

To: fvogt, #plasma, #frameworks
Cc: romangg, graesslin, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180616/61d855fd/attachment.html>