D13510: Add XDG WM Base support to our XDGShell API

Vlad Zagorodniy noreply at phabricator.kde.org
Fri Jun 15 19:00:00 UTC 2018


zzag added inline comments.

INLINE COMMENTS

> xdgshell_stable.cpp:305
> +    Q_UNUSED(surface)
> +    auto s = reinterpret_cast<Private*>(data);
> +    s->q->configureRequested(s->pendingSize, s->pendingState, serial);

Did you forget to change it to static_cast? Or there is a reason why it's still reinterpret_cast?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180615/9b14707f/attachment.html>


More information about the Kde-frameworks-devel mailing list