D13510: Add XDG WM Base support to our XDGShell API

David Edmundson noreply at phabricator.kde.org
Fri Jun 15 16:39:52 UTC 2018


davidedmundson marked 4 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> romangg wrote in xdgshell_stable_interface.cpp:246
> Wrong id `XDG_WM_BASE_ERROR_ROLE`.

What role do you think it should be?

I'm using the error for when a wl_surface has another role in the case that you call get_xdg_surface twice on the same wl_surface, which seems close enough.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180615/e447b4b0/attachment.html>


More information about the Kde-frameworks-devel mailing list