D13510: Add XDG WM Base support to our XDGShell API

[David Edmundson]

davidedmundson marked 10 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in test_xdg_shell.cpp:120
> Missing `default`. Is it okay if version is unknown?

IMHO it's better not to as it means we get a compile time warning in the unlikely event that someone adds a new value to the enum without updating this.

> zzag wrote in xdgshell_stable_interface.cpp:242-243
> Which one should return?

oops, thanks

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180613/a4c8dca0/attachment.html>