D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

Ralf Habacker noreply at phabricator.kde.org
Fri Jun 8 12:04:01 UTC 2018


habacker added a comment.


  In D13406#275375 <https://phabricator.kde.org/D13406#275375>, @cgiboudeaux wrote:
  
  > -1, this change would break the autotests.
  
  
  Hmmh, https://cmake.org/cmake/help/v3.0/variable/CMAKE_CURRENT_LIST_DIR.html mentions  "... that As CMake processes the listfiles in your project this variable will always be set to the directory where the listfile which is currently being processed (CMAKE_CURRENT_LIST_FILE) is located." so it should work. Adding `message("++++ ${CMAKE_CURRENT_LIST_DIR"}` to KF5I18nMacros.cmake returns `++++++ <build-root>/autotests/cmake`, which looks correct. 
  The failure happens on running `make test`, which inside runs `make install` in the build dir of the configured ki18_install autotests (located in `<buildroot>/autotests/ki18n_install`), where `-P ${CMAKE_CURRENT_LIST_DIR}/build-tsfiles.cmake` is expanded to  `-P <ki18n-src-root>/cmake/build-pofiles.cmake` - Seems to be a cmake bug

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D13406

To: habacker, ilic
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180608/6e4c037d/attachment.html>


More information about the Kde-frameworks-devel mailing list