D13384: FrameSvg: Do not wreck shared mask frames

Vlad Zagorodniy noreply at phabricator.kde.org
Thu Jun 7 21:36:28 UTC 2018


zzag updated this revision to Diff 35806.
zzag added a comment.


  Rename `shouldUpdateSizes` back to `shouldUpdate`
  
  That's for a possible future diff: the mask frame should be updated
  if maskFrame->imagePath != frame->imagePath. That's an unrelated
  change because this diff tries to address the problem of corrupting
  already shared mask frames.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13384?vs=35749&id=35806

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13384

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180607/bca67151/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list