D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

Heiko Becker noreply at phabricator.kde.org
Thu Jun 7 12:38:39 UTC 2018


heikobecker marked an inline comment as done.
heikobecker added a comment.


  Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime.

INLINE COMMENTS

> ltoscano wrote in KF5I18NMacros.cmake.in:138-139
> I guess that those two lines are the critical parts (the call to file), but probably it's not bad to avoid processing other instructions too.

Yes. And that was my thought as well and reason to move the rest inside the if

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180607/62caa973/attachment.html>


More information about the Kde-frameworks-devel mailing list