D13328: A backend is required for kdnssd

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> adridg wrote in CMakeLists.txt:65-66
> Hi. If you're posting a review, please provide constructive input. If there are policies or guidelines about places, please link to them. If there aren't, but you would prefer a change, please describe the (outline of the) change. If you mean "there should be an additional space in the else() statement to match the text formatting from line 57", then write that.

your else() follows if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po"), I thought the comment was clear.

Your current patch means:  if there's no "po" subdir, throw a fatal error with an unrelated message.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13328

To: adridg
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180604/2f05abea/attachment-0001.html>