D13215: Update sizes before generating frame svg background

Vlad Zagorodniy noreply at phabricator.kde.org
Fri Jun 1 11:20:04 UTC 2018


zzag added subscribers: aseigo, mart.
zzag added a comment.


  In D13215#271983 <https://phabricator.kde.org/D13215#271983>, @broulik wrote:
  
  > +1
  >
  > Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it worse either. Please also profile whether it causes any needless recalculations on Plasma startup
  
  
  I'd like to dig deeper why margins do not correspond to enabled margins. Maybe, because of
  
    if (!d->repaintBlocked) {
       d->updateFrameData();
    }
  
  FrameSVG misses to update margins, and so on.
  
  I really would like to here opinion of @mart and @aseigo . Maybe, there is a better way to fix this.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180601/185f8ede/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list