D14162: Figure out the escaped path list on kconfig
Anthony Fieroni
noreply at phabricator.kde.org
Tue Jul 31 11:47:08 BST 2018
anthonyfieroni added inline comments.
INLINE COMMENTS
> kconfiggroup.cpp:176
> + last = p + 1;
> + } else if (data[p] == QLatin1Char('\\')) {
> + escapedLast = true;
It should be
p < data.size() && data[p] == '\\'
or you will access not owned memory. Better is to cache data.size() in variable then to use it everywhere.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D14162
To: apol, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180731/0218c291/attachment.html>
More information about the Kde-frameworks-devel
mailing list