D14501: Top-align labels in properties dialog

[Henrik Fehlauer]

rkflx created this revision.
rkflx added reviewers: dhaumann, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
rkflx requested review of this revision.

REVISION SUMMARY
  The General tab of KIO's properties dialog shows labels on the
  left side, and properties on the right, creating a table-like structure.
  Commonly a label should be aligned vertically in such a way it matches
  the first line of the properties, to make it clear which properties it
  belongs to.
  
  However, this was not yet the case for the Size label.

TEST PLAN
  In Dolphin, select a folder and press [Alt] + [Return]. All labels in
  Properties > General should be top-aligned.
  Before: F6165126: kio-properties-before.png <https://phabricator.kde.org/F6165126>
  After: F6165125: kio-properties-after.png <https://phabricator.kde.org/F6165125>

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-alignment-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14501

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: rkflx, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180730/f21c3b34/attachment.html>