D14435: Fix KTimeComboBox input mask for AM/PM times

Laurent Montel noreply at phabricator.kde.org
Mon Jul 30 07:06:53 BST 2018


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ktimecomboboxtest.cpp:198
> +    QString mask = m_combo->lineEdit()->inputMask();
> +    QCOMPARE(mask.contains(QLatin1String("aa")), true);
> +    delete m_combo;

Could you provide another case where mask will not contains "aa" so we can be sure that code works
Thanks.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14435

To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180730/a430a21d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list