D14447: Sonnet: setLanguage should schedule a rehighlight if highlight is enabled

David Faure noreply at phabricator.kde.org
Sat Jul 28 23:37:36 BST 2018


dfaure created this revision.
dfaure added reviewers: sandsmark, mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  ... even if automatic enabling/disabling is off, as is the case in KMail.
  
  This will allow removing a direct call to rehighlight() in kpimtextedit
  which leads to the full highlighting being done twice (very slow on very
  large emails).

TEST PLAN
  Replying to a mail in kmail and watching how many times
  slotRehighlight is called. Well, this commit alone makes it worse,
  but after a fix in kpimtextedit, it's down from 2 to 1.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14447

AFFECTED FILES
  src/ui/highlighter.cpp

To: dfaure, sandsmark, mlaurent
Cc: kde-frameworks-devel, #kde_pim, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180728/46913755/attachment.html>


More information about the Kde-frameworks-devel mailing list