D14360: Remove custom icon selection for trash

Pino Toscano noreply at phabricator.kde.org
Sat Jul 28 07:21:24 BST 2018


pino added a comment.


  In D14360#299443 <https://phabricator.kde.org/D14360#299443>, @shubham wrote:
  
  > pino: suppose this function is created(canEditIcon()),then this function must  also be called when we are creating the m_iconButton at line 123 so as to generalize it's creation ( as you had said to take into account other entries also if they are also to be excluded).
  
  
  The function I suggested shows to the external users of `KFilePlaceEditDialog` (which is only the static `KFilePlaceEditDialog::getInformation()`) whether the icon could be edited or not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180728/fb562026/attachment.html>


More information about the Kde-frameworks-devel mailing list