D14360: Remove custom icon selection for trash

Pino Toscano noreply at phabricator.kde.org
Sat Jul 28 06:45:45 BST 2018


pino added a comment.


  In D14360#299441 <https://phabricator.kde.org/D14360#299441>, @shubham wrote:
  
  > indirectly you mean to transfer all the logic to helper function
  
  
  No, I suggested something like:
  
    bool KFilePlaceEditDialog::canEditIcon() const
    {
      return m_iconButton;
    }
  
  using it in `KFilePlaceEditDialog::getInformation()`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180728/61c8a95e/attachment.html>


More information about the Kde-frameworks-devel mailing list