D14360: Remove custom icon selection for trash

[Pino Toscano]

pino added a comment.


  In D14360#299439 <https://phabricator.kde.org/D14360#299439>, @shubham wrote:
  
  > pino, I understood your idea of having a helper class function, but the condition for editing the icon will remain the same ( based on its scheme), what can be the other condition?
  
  
  For example if in the future you exclude another scheme from icon editing. Generally speaking, there is a logic here (`url.scheme() != QLatin1String("trash")`), and usually duplicating it even across the very same source file is not a good idea.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180728/0f8fb5b3/attachment.html>