D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> parser.cpp:58
>                  parseMetadataXml(xml);
> -            } else if (elements.contains(xml.name().toString())) {
> +            } else if (stringList_contains_stringRef(elements, xml.name())) {
>                  item = parseXml(xml);

You could also use

  if (std::any_of(elements.begin(), elements.end(),
                  [&xml](const auto& e) { return e == xml.name(); }) {

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D14401

To: apol, leinir, whiting, aacid
Cc: bruns, aacid, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180727/7ad795be/attachment.html>