D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Jul 27 11:16:32 BST 2018


apol added a comment.


  In D14401#298611 <https://phabricator.kde.org/D14401#298611>, @aacid wrote:
  
  > Does this really make a difference?
  
  
  I was looking at heaptrack and this function was a point of contention, maybe not a big deal.
  
  > Also... fix qt to get QStringList::containst(QStringRef)?
  
  Last time I submitted a QStringRef overload to Qt, QStringView-man told me it was the wrong thing to do and he had everything figured out. I can do it though.

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14401

To: apol, leinir, whiting, aacid
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180727/6a18c203/attachment.html>


More information about the Kde-frameworks-devel mailing list