D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Jul 26 12:27:36 BST 2018


apol created this revision.
apol added reviewers: leinir, whiting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's just not overloaded by QStringList, so we keep a local definition here.

TEST PLAN
  tests still pass, discover still runs.

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14401

AFFECTED FILES
  src/parser.cpp

To: apol, leinir, whiting
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180726/426a4d7b/attachment.html>


More information about the Kde-frameworks-devel mailing list