D14395: [KSambaShare] Check file that's changed before reloading

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Jul 26 08:51:48 BST 2018


broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We use the `KDirWatch` singleton so we might get signals for files we're not interested in

TEST PLAN
  Dolphin no longer constantly reloads samba configuration while copying a directory.
  `sync()` is still called once when I change Samba share settings in file properties dialog.
  The view does not update the shared badge automatically but that also doesn't work without this patch so is a separate bug

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14395

AFFECTED FILES
  src/core/ksambashare.cpp

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180726/ce694566/attachment.html>


More information about the Kde-frameworks-devel mailing list