D14360: Remove custom icon selection for trash

Nathaniel Graham noreply at phabricator.kde.org
Wed Jul 25 20:24:35 BST 2018


ngraham requested changes to this revision.
ngraham added a reviewer: Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.


  It's important to test your changes before submitting. :) This now causes Gwenview to segfault when you try to edit its Trash entry. The reason is because now that `m_iconButton` isn't added to the layout, the line beginning with `layout->labelForField()` crashes when it tries to run, since `m_iconButton isn't in a layout. That needs to be moved into the conditional as well.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180725/076bed58/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list