D14291: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction

David Edmundson noreply at phabricator.kde.org
Mon Jul 23 10:56:04 BST 2018


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The destructor or Resource::~Resource will delete the d-pointer used by
  Resource before we reach QObject::~QObject() of the resource which emits
  the destroyed signal. This means this lamba is accessing deleted
  contents.
  
  Based on
  https://build.kde.org/view/Frameworks/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/71/testReport/
  
  aboutToBeUnbound is emitted before object destruction.

TEST PLAN
  Relevant unit test still passes and this lambda is still invoked.

REPOSITORY
  R127 KWayland

BRANCH
  dave

REVISION DETAIL
  https://phabricator.kde.org/D14291

AFFECTED FILES
  src/server/remote_access_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180723/993cc00f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list