D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Jul 23 10:18:52 BST 2018
broulik created this revision.
broulik added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
It checks whether the file is not in `TEMP` but it doesn't check whether the `QUrl` is valid.
It opens `destination` when you click the button which fails when it is invalid/empty.
CCBUG: 396738
TEST PLAN
Buttons no longer show when there is no destination
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D14290
AFFECTED FILES
src/kwidgetjobtracker.cpp
To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180723/ec9cc06e/attachment.html>
More information about the Kde-frameworks-devel
mailing list