D14187: Fix variable definition check

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Jul 17 15:38:04 BST 2018


apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  We'd check if the variable's value is defined, which is wrong and prevented us
  from properly initialising using these deprecated variables.
  It would also ignore the value we're passing to the actually right variable when
  using it.

TEST PLAN
  Built kstars which needs -DCMAKE_ANDROID_API=24

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14187

AFFECTED FILES
  toolchain/Android.cmake

To: apol, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180717/9ebedabc/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list