D14161: [KStyle] Use dialog-question for question icon

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jul 16 16:46:58 BST 2018


broulik created this revision.
broulik added reviewers: dfaure, ngraham, rkflx.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was changed in `KMessageBox` in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 <https://phabricator.kde.org/R236:9b05a12a43dbe2b31a4655052f20de0832ac7a61> but never "upstreamed" to `KStyle` which wasn't an issue until D14160 <https://phabricator.kde.org/D14160>
  
  `dialog-information` is kept as a fallback since e.g. Oxygen doesn't have `dialog-question` since using that icon is a pretty new addition

TEST PLAN
  `kdialog --yesno "test"` shows question mark icon again in Breeze. shows information icon still with Oxygen.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D14161

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180716/fda05e15/attachment.html>


More information about the Kde-frameworks-devel mailing list