D14160: [KMessageBox] Call style for icon

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jul 16 16:41:58 BST 2018


broulik created this revision.
broulik added reviewers: dfaure, kfunk.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `QMessageBox::standardIcon` is deprecated. Also, both `QCommonStyle` does exactly what we do here, and so does `KStyle`.

TEST PLAN
  Tests still pass. Dialog icons are correct on Linux with Breeze, Fusion, and Windows 95 style.
  This needs testing on Windows and Mac as there it might use the system-provided graphics now?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14160

AFFECTED FILES
  src/kmessagebox.cpp

To: broulik, dfaure, kfunk
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180716/4403407a/attachment.html>


More information about the Kde-frameworks-devel mailing list