D12295: Supporting nested brackets for Kate autobrackets

Christoph Cullmann noreply at phabricator.kde.org
Sat Jul 14 19:36:09 BST 2018


cullmann added a comment.


  I like the idea.
  For the patch:
  
  I think one should check with isEmpty() if the thing is empty, instead of the size() > 0 things, thats more clear.
  And is there no m_currentAutobraceClosingChar clear missing somewhere? e.g. don't go this two stack out of sync?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12295

To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180714/143e58d2/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list