D13814: Speedup sort
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sat Jul 14 14:09:44 BST 2018
bruns added a comment.
In D13814#291757 <https://phabricator.kde.org/D13814#291757>, @jtamate wrote:
> In D13814#291644 <https://phabricator.kde.org/D13814#291644>, @bruns wrote:
>
> > Any reason why you have pushed this with an obviously wrong commit message?
>
>
> Because I though the commit message was right.
>
> What should it be?
The new code uses a reference to the collator instead of copying and reinitializing it again and again. This is the reason for the speedup.
Changing the implementation from a Functor class to a Lambda removes some boilerplate code, but is not relevant for performance.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D13814
To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180714/98cc83ee/attachment.html>
More information about the Kde-frameworks-devel
mailing list