D14107: [Telegram] Don't wait for Telegram to be closed

Nicolas Fella noreply at phabricator.kde.org
Sat Jul 14 06:56:33 BST 2018


nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Unlike e.g. kdeconnect-cli telegram stays open after sharing. The Job lives as long as telegram is running, 
  although the exit code is not interesting. Another window with a useless progress bar is open all the time, 
  which is especially annoying when using a tiling window manager. This patch waits shortly and stops the job 
  while keeping telegram open. Directly stopping the job would cause telegram not to open at all. The waiting 
  time is somewhat ad-hoc, but works well in my case.

TEST PLAN
  Share something via Telegram. See progress window open shortly and close again. Telegram stays
  open, ready to share

REPOSITORY
  R495 Purpose Library

BRANCH
  finishtelegramjob

REVISION DETAIL
  https://phabricator.kde.org/D14107

AFFECTED FILES
  src/plugins/telegram/telegramplugin.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180714/cf9e37a4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list