D14072: Don't try to restore invalid user places

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Don't restore user places with invalid attribute href.
  This avoids asking for empty protocol in KFilePlacesItem::groupType and the assert in KProtocolInfoFactory::findProtocol.

TEST PLAN
  Don't assert asking for invalid protocols when creating the save dialog with an invalid bookmark (empty href) in ~/.local/share/user-places.xbel
  
    <bookmark href="">
     <title>Project Folder</title>
     <info>
      <metadata owner="http://freedesktop.org">
       <bookmark:icon name="folder-favorites"/>
      </metadata>
      <metadata owner="http://www.kde.org">
       <OnlyInApp>kdenlive</OnlyInApp>
      </metadata>
     </info>
    </bookmark>

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14072

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180712/e9b255ee/attachment.html>