D13816: Make KItinerary work as a static library

Christophe Giboudeaux noreply at phabricator.kde.org
Tue Jul 10 13:52:50 BST 2018


cgiboudeaux added inline comments.

INLINE COMMENTS

> lepagevalleeemmanuel wrote in CMakeLists.txt:50
> You *might* want to add
> 
>   OPTION(BUILD_SHARED_LIBS   "Build the shared library (instead of static)" ON )
> 
> near the top of the `CMakeLists.txt` for the sake of making sure it's the default and for readability?

No need, extra-cmake-modules already sets it to TRUE if KDECMakeSettings is included.

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D13816

To: vkrause, #frameworks
Cc: cgiboudeaux, arojas, mart, lepagevalleeemmanuel, apol, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180710/8d344469/attachment.html>


More information about the Kde-frameworks-devel mailing list