D14009: [Plasma PluginLoader] Cache plugins during startup

Vlad Zagorodniy noreply at phabricator.kde.org
Mon Jul 9 20:01:44 BST 2018


zzag added inline comments.

INLINE COMMENTS

> pluginloader.cpp:194-196
> +    const QString pluginName = name.section(QLatin1Char('/'), -1);
>  
> +    QVector<KPluginMetaData> plugins;

Nitpick: IMHO, it would be better to move these two down (right before `if (useRuntimeCache) {`). So, cache invalidation and cache population stuff goes first, then querying stuff.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14009

To: broulik, #plasma, davidedmundson, mart
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180709/18784521/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list