D13814: Speedup sort

Jaime Torres Amate noreply at phabricator.kde.org
Mon Jul 9 08:18:31 BST 2018


jtamate updated this revision to Diff 37422.
jtamate edited the summary of this revision.
jtamate added a comment.


  Created the bug report referenced in the summary and code.
  Changed the strings to compare, they can be anything.
  
  > Perhaps there is a remote possibility of closing a view while sorting which will cause the lessThan lambda to have a dangling reference to m_collator and crash.
  
  Right now this possibility is non-existent, sort does not allows any event management, and in fact I thing is this bug report: https://bugs.kde.org/show_bug.cgi?id=395374

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13814?vs=37305&id=37422

REVISION DETAIL
  https://phabricator.kde.org/D13814

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp
  src/kitemviews/kfileitemmodel.h

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180709/1c31b048/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list