D13921: Don't show confirmation dialog for Trash action by default

[Алексей Шилин]

aleksejshilin added a comment.


  In D13921#288012 <https://phabricator.kde.org/D13921#288012>, @ngraham wrote:
  
  > There's a problem with the git setup on the computer you used to make this commit; the `name` field appears to be empty, so I get an error when I try to apply the patch
  
  
  That's weird. It is the very same machine which I previously used to submit all of my revisions, and actual commits look fine, too <https://cgit.kde.org/plasma-workspace.git/commit/?id=eaa093443a7ce7ee2befd321a974d4d7a8ad7801>. I'll look into it tomorrow when I get to that PC.
  
  In D13921#288014 <https://phabricator.kde.org/D13921#288014>, @ngraham wrote:
  
  > Are you planning to update `konqueror/settings/konq/behaviour.cpp` as the comment asked? ;)
  
  
  As @dfaure said, these things are no longer there, that's why I had changed the comment to point to the new location.
  
  In D13921#288178 <https://phabricator.kde.org/D13921#288178>, @ngraham wrote:
  
  > Do you have commit access yet?
  
  
  I do, thanks! Will land tomorrow.

REPOSITORY
  R241 KIO

BRANCH
  dont_confirm_trash

REVISION DETAIL
  https://phabricator.kde.org/D13921

To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180708/afcb7da8/attachment.html>