D13674: Make it possible to go up to root again
David Faure
noreply at phabricator.kde.org
Sat Jul 7 23:27:16 BST 2018
dfaure added a comment.
The unittest fails in CI, please take a look.
https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/313/testReport/(root)/TestSuite/kiofilewidgets_kfilewidgettest/
When I tried running the test locally, I got a prompt from sftp about verifying the identity of 127.0.0.1 .... not great for a unittest, to ask for user input.
This also means the test is dependent on kio_sftp being installed? That's no good, it's not part of KIO, so it's not available for CI.
Please use a URL that is sure to work (maybe FTP on a public site), or better, somehow stub out any actual kioslave usage, and *just* test URLs.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13674
To: jtamate, dfaure, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180707/d5518563/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list