D12945: kcoredirlister lstItems benchmark

[David Faure]

dfaure added a comment.


  It's also interesting to look at numbers for small directories (which is still the most common case, too).
  
  This code could use a run of uncrustify to match the coding style of the rest of kio, but otherwise it looks good.

INLINE COMMENTS

> kcoredirlister_benchmark.cpp:372
> +//BEGIN List
> +// List Implementation (without the NonMovable part)
> +class ListImplementation:public Base

In the long run, people will really wonder what's that about, since your other commit will remove the NonMovableList class/hack ;)

> kcoredirlister_benchmark.cpp:679
> +    data.f.setMimeFilter(QStringList("text/text"));
> +    QUrl directoryUrl = QUrl::fromLocalFile("");
> +    // Add every item in data.lstItems

fromLocalFile("") doesn't look valid to me

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12945

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180706/86b68694/attachment.html>